RFR: 8278479: RunThese test failure with +UseHeavyMonitors and +VerifyHeavyMonitors

Daniel D. Daugherty dcubed at openjdk.org
Fri Jul 1 14:40:27 UTC 2022


On Thu, 30 Jun 2022 22:05:14 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> This change adds a null check before calling into Runtime1::monitorenter when -XX:+UseHeavyMonitors is set. There's a null check in the C2 and interpreter code before calling the runtime function but not C1.
> 
> Tested with tier1-7 (a little of 8) and built on most non-oracle platforms as well.

The changes look good, but it has been a long time since I've
looked at C1 code so my opinion is rusty...

Thanks for testing with Mach5 Tier[1-7]. Did you do any targeted
testing with -XX:+UseHeavyMonitors and -XX:+VerifyHeavyMonitors
with RunThese?

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9339


More information about the hotspot-compiler-dev mailing list