RFR: 8289856: [PPC64] SIGSEGV in C2Compiler::init_c2_runtime() after JDK-8289060 [v2]

Dean Long dlong at openjdk.org
Thu Jul 7 08:04:37 UTC 2022


On Thu, 7 Jul 2022 07:59:16 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> We're currently calling `nullptr->is_valid()` and `nullptr->value()` which causes SIGSEGV on PPC64 (and is undefined behavior). See JBS for details.
>
> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use VMRegImpl::Bad() for vector registers and remove null check again.

Marked as reviewed by dlong (Reviewer).

src/hotspot/share/opto/c2compiler.cpp line 67:

> 65:   }
> 66: 
> 67:   for (OptoReg::Name i=OptoReg::Name(0); i<OptoReg::Name(REG_COUNT); i = OptoReg::add(i,1)) {

I don't think it's worth it to change this line just because of white space.

-------------

PR: https://git.openjdk.org/jdk/pull/9403


More information about the hotspot-compiler-dev mailing list