RFR: 8288883: C2: assert(allow_address || t != T_ADDRESS) failed after JDK-8283091

[Fei Gao]

On Thu, 7 Jul 2022 18:54:06 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> In which call to `adjust_alignment_for_type_conversion()` you got AddP node? Should we add checks there too?

Thanks for your review, @vnkozlov .

When we called `adjust_alignment_for_type_conversion()` in `SuperWord::follow_def_uses()`, https://github.com/openjdk/jdk/blob/3f1174aa4709aabcfde8b40deec88b8ed466cc06/src/hotspot/share/opto/superword.cpp#L1525, we got AddP node. In this function, we also call `stmts_can_pack()` on the next line, which has checks to prevent unwanted pairs, https://github.com/openjdk/jdk/blob/3f1174aa4709aabcfde8b40deec88b8ed466cc06/src/hotspot/share/opto/superword.cpp#L1202. Maybe we don't have to add one more. WDYT?

-------------

PR: https://git.openjdk.org/jdk/pull/9391