RFR: 8288897: Clean up node dump code [v3]
Emanuel Peter
epeter at openjdk.org
Fri Jul 8 14:44:38 UTC 2022
On Mon, 27 Jun 2022 07:01:41 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> I did think about renaming it do `dump_...`. But then I also find it important that the name says that we do filter / search / find.
>
> The filter/search action is probably implied but I don't have a strong opinion about it - it's fine to leave the name like that. But I suggest to make it plural (`find_nodes_by_dump()`) as we are possibly returning multiple nodes.
I like the idea with the plural. But I will keep the `find`
-------------
PR: https://git.openjdk.org/jdk/pull/9234
More information about the hotspot-compiler-dev
mailing list