[jdk19] RFR: 8288112: C2: Error: ShouldNotReachHere() in Type::typerr()

Dean Long dlong at openjdk.org
Fri Jul 8 23:27:48 UTC 2022


On Fri, 8 Jul 2022 21:57:33 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

> [JDK-8284960](https://bugs.openjdk.org/browse/JDK-8284960) added new vector IR nodes and target specific backend support for  Reverse Byte vector operations.  
> Auto-vectorization analysis based on vector IR opcode existence and target backed implementation for existing Java SE APIs [Short/Character/Integer/Long].reverseBytes passes since both vector IR and backend support already exist for these operations. This bug fix patch handled missing scalar reverse byte IR cases in SLP optimizer to enable creation of corresponding vector IR nodes.
> 
> A new JBS issue [JDK-8290034](https://bugs.openjdk.org/browse/JDK-8290034) is created to add the missing auto-vectorization support for bit reverse operation targeting JDK mainline.
> 
> Kindly review and share your feedback.
> 
> Best Regards,
> Jatin

Looks good to me, but I still have a problem with the error message.  It seems like we could give a better error message if we detected the missing vectorization support earlier.  What do you think?

-------------

PR: https://git.openjdk.org/jdk19/pull/128


More information about the hotspot-compiler-dev mailing list