RFR: 8290066: Remove KNL specific handling for new CPU target check in IR annotation

Vladimir Kozlov kvn at openjdk.org
Mon Jul 11 16:41:43 UTC 2022


On Mon, 11 Jul 2022 12:55:02 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

> - Newly added annotations query the CPU feature using white box API which returns the list of features enabled during VM initialization.
> - With JVM flag UseKNLSetting, during VM initialization AVX512 features not supported by KNL target are disabled, thus we do not need any special handling for KNL in newly introduced IR annotations (applyCPUFeature, applyCPUFeatureOr, applyCPUFeatureAnd).
> 
> Please review and share your feedback.
> 
> Best Regards,
> Jatin

test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java line 138:

> 136:                     "Xlog",
> 137:                     "UseAVX",
> 138:                     "UseKNLSetting",

I don't think we should add these flags to whitelist in these changes - they can affect generated code.
New RFE is filed already to handle such flags: [8289801](https://bugs.openjdk.org/browse/JDK-8289801)

-------------

PR: https://git.openjdk.org/jdk/pull/9452


More information about the hotspot-compiler-dev mailing list