[jdk19] RFR: 8288112: C2: Error: ShouldNotReachHere() in Type::typerr()

[Jatin Bhateja]

On Mon, 11 Jul 2022 21:01:35 GMT, Dean Long <dlong at openjdk.org> wrote:

>>> @jatin-bhateja Right, a better error message wouldn't be a value-add to users, but if we could detect it sooner, like in SuperWord::output(), that might be useful to compiler engineers debugging issues.
>> 
>> Hi @dean-long , Agree, I have changed the error message generated with -XX:+TraceLoopOpts to be more explicit like.
>> **SWPointer::output: Unhandled scalar opcode (ReverseBytesI), ShouldNotReachHere, exiting SuperWord**
>> 
>> Since patch already handles the missing scalar case, hence this message will not be generated.
>
> @jatin-bhateja OK, thanks.

Hi @dean-long , kindly approve if the patch version looks ok to you.

-------------

PR: https://git.openjdk.org/jdk19/pull/128