RFR: 8290164: compiler/runtime/TestConstantsInError.java fails on riscv

Feilong Jiang fjiang at openjdk.org
Thu Jul 14 01:19:59 UTC 2022


On Tue, 12 Jul 2022 09:46:24 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> compiler/runtime/TestConstantsInError.java fails on riscv with the following error:
>> 
>> 
>> Execution failed: `main' threw exception: java.lang.RuntimeException: 'made not entrant' found in stdout
>> 
>> 
>> Similar to AArch64, RISCV64 does not patch C1 compiled code (see [JDK-8223613](https://bugs.openjdk.org/browse/JDK-8223613)). So we should add `Platform.isRISCV64` too for the test.
>> 
>> This test requires vm.flagless. According to [JDK-8246494](https://bugs.openjdk.org/browse/JDK-8246494), tests with `vm.flagless` will be excluded from runs w/ any other X / XX flags passed via -vmoption / -javaoption. 
>> Since we added `-Xmx` option for all jtreg tests, so this failure does not menifest before. 
>> 
>> After this fixing, compiler/runtime/TestConstantsInError.java passed without failure.
>
> Looks good and reasonable.

@RealFYang -- thanks for the review! Integrate then.

-------------

PR: https://git.openjdk.org/jdk/pull/9463


More information about the hotspot-compiler-dev mailing list