Integrated: 8290246: test fails "assert(init != __null) failed: initialization not found"

[Vladimir Kozlov]

On Thu, 14 Jul 2022 18:09:49 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> CTW test (which compiles methods without running them - no profiling) failed when run with stress flag and particular RNG seed `-XX:+StressIGVN -XX:StressSeed=1743550013`. The failure is intermittent because of RNG.
> 
> The compiled method [BasicPopupMenuUI$BasicMenuKeyListener::menuKeyPressed()](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicPopupMenuUI.java#L331) has allocation in loop at line [L360](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicPopupMenuUI.java#L360) which is followed by call `item.isArmed()` at line L366. This call is not "linked" and uncommon trap is generated for it. As result the allocation result become un-used.
> Due to shuffling done with `StressIGVN` flag LoadRangeNode is processed after InitializeNode is removed from graph but AllocateArrayNode is not. We hit assert because of that.
> 
> The fix replaces the assert with check.
> 
> Tested with replay file from bug report. I was not able to reproduce failure with standalone test because it is hard to force LoadRangeNode processing at right time. I attached to bug report a test which work on.
> 
> Testing tier1-3,xcomp

This pull request has now been integrated.

Changeset: 70fce07a
Author:    Vladimir Kozlov <kvn at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/70fce07a382896a8091413d7269bb16f33122505
Stats:     7 lines in 1 file changed: 3 ins; 0 del; 4 mod

8290246: test fails "assert(init != __null) failed: initialization not  found"

Reviewed-by: dlong, iveresov

-------------

PR: https://git.openjdk.org/jdk/pull/9497