RFR: JDK-8290069: IGV: Highlight both graphs of difference in outline

Tobias Hartmann thartmann at openjdk.org
Mon Jul 18 10:29:04 UTC 2022


On Tue, 12 Jul 2022 13:10:37 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:

> Previously, IGV highlighted only one graph in the outline when a difference graph is selected using the sliders. 
> Now, IGV highlights both graphs used to calculate the difference graph when they are in the same group. 
> 
> <img width="395" alt="highlight both graphs" src="https://user-images.githubusercontent.com/71546117/178496847-d9a69e59-9292-43eb-bbfd-8e21de3aa809.png">
> 
> IGV colors the nodes in a difference graph with yellow/red/green to highlight the changes. This only worked if the difference graph is calculated using the sliders. Now, difference graphs is also coloured when calculated via the context menu "Difference to current graph" in the outline. 
> 
> <img width="522" alt="Show colors" src="https://user-images.githubusercontent.com/71546117/178498687-5675e797-70b8-4c0f-91ad-6f35abf8ecb8.png">

Looks good.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9468


More information about the hotspot-compiler-dev mailing list