RFR: JDK-8290016: IGV: Fix graph panning when mouse dragged outside of window [v2]
Tobias Hartmann
thartmann at openjdk.org
Thu Jul 21 12:37:06 UTC 2022
On Wed, 20 Jul 2022 15:10:47 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:
>> A graph in IGV can be moved by dragging it with the left mouse button (called panning).
>> 
>>
>> If the mouse left the visible window of the graph during dragging, the diagram started to move in the opposite direction. This was annoying. Now panning stops as soon as the mouse leaves the window.
>> 
>>
>> In selection mode, the graph still moves when the mouse is dragged outside the window, as this is meant to make a larger selection.
>> 
>
> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>
> fixed locking in CustomizablePanAction
Looks reasonable.
src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/actions/CustomizablePanAction.java line 4:
> 2: * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
> 3: *
> 4: * Copyright (c) 1997, 2015, 2022, Oracle and/or its affiliates. All rights reserved.
Suggestion:
* Copyright (c) 1997, 2022, Oracle and/or its affiliates. All rights reserved.
-------------
Marked as reviewed by thartmann (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9470
More information about the hotspot-compiler-dev
mailing list