RFR: 8289996: Fix array range check hoisting for some scaled loop iv [v2]
Pengfei Li
pli at openjdk.org
Fri Jul 22 04:12:02 UTC 2022
On Tue, 19 Jul 2022 10:13:56 GMT, Quan Anh Mai <duke at openjdk.org> wrote:
>> Pengfei Li has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Address comment from merykitty
>
> Thanks, it looks good to me, maybe we would need similar tests for long range checks also.
@merykitty @rose00 Thanks for all your comments. Please see my updated code.
After some investigation on memory segment accesses, I see this does help 64-bit long range checks. As memory segment access introduces quite a lot of IRs, I rewrite the jtreg case and turn to checking the output of `-XX:+TraceLoopPredicate` to make the test more accurate.
I have re-tested tier1, also checked that the new jtreg would fail without my changes in `mulnode.cpp`.
-------------
PR: https://git.openjdk.org/jdk/pull/9508
More information about the hotspot-compiler-dev
mailing list