RFR: 8290834: Improve potentially confusing documentation on collection of profiling information [v2]

Julian Waters jwaters at openjdk.org
Fri Jul 22 07:43:11 UTC 2022


On Fri, 22 Jul 2022 01:11:04 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Correct comment with respect to review
>
> src/hotspot/share/compiler/compilationPolicy.hpp line 48:
> 
>> 46:  * all data from the MDO will be loaded into the ciMethodData when it is first created.
>> 47:  * (See ciMethod::method_data() in ciMethod.cpp for more details)
>> 48:  *
> 
> The ciMethodData is just a temporary snapshot.  Updates to the profiling data is still done through the MethodData.

The only place I could find a MethodData being created is in the method

// Build a MethodData* object to hold information about this method
// collected in the interpreter.
void Method::build_interpreter_method_data(const methodHandle& method, TRAPS)

which presumably constructs a MethodData for profiling in the Interpreter. Is there a different area where it's created (when profiling with C1) that I missed?

-------------

PR: https://git.openjdk.org/jdk/pull/9598


More information about the hotspot-compiler-dev mailing list