RFR: 8290834: Improve potentially confusing documentation on collection of profiling information [v2]

Vladimir Kozlov kvn at openjdk.org
Fri Jul 22 18:42:17 UTC 2022


On Fri, 22 Jul 2022 08:51:55 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Correct comment with respect to review
>
> C1 uses ciMethod::ensure_method_data(), which calls Method::build_interpreter_method_data(), to create an MDO if one wasn't already created by the interpreter.  So the name build_interpreter_method_data() is a bit misleading, because C1 will use the same MDO as the interpreter.
> 
> I also found a comment in c1_globals.hpp about C1UpdateMethodData that mentions tier1.  I think the  comment should be changed to say tier3.

@dean-long posted his comment before I finished my :)
But we are saying the same thing.

-------------

PR: https://git.openjdk.org/jdk/pull/9598


More information about the hotspot-compiler-dev mailing list