RFR: 8287393: AArch64: Remove trampoline_call1 [v2]

Andrew Haley aph at openjdk.org
Tue Jul 26 14:46:05 UTC 2022


On Tue, 26 Jul 2022 14:22:42 GMT, Evgeny Astigeevich <duke at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 637:
>> 
>>> 635:       // code.
>>> 636:       PhaseOutput* phase_output = Compile::current()->output();
>>> 637:       in_scratch_emit_size =
>> 
>> Looks reasonable enough. The only change is to check for `Compile::current()->output()` being null, right?
>
> Hi @theRealAph,
> I am sorry I did not get your comment. Could you please explain it?
> 
> Thanks,
> Evgeny

The addition is
'PhaseOutput* phase_output = Compile::current()->output();'
then
'phase_output != NULL && phase_output->in_scratch_emit_size()'

so AFAICS `Compile::current()->output()` is now checked for null, where it was not before.

-------------

PR: https://git.openjdk.org/jdk/pull/9592


More information about the hotspot-compiler-dev mailing list