RFR: 8289925: Shared code shouldn't reference the platform specific method frame::interpreter_frame_last_sp() [v2]

Andrew Haley aph at openjdk.org
Thu Jul 28 08:54:44 UTC 2022


On Tue, 26 Jul 2022 20:43:48 GMT, Dean Long <dlong at openjdk.org> wrote:

> Are you sure unextended_sp() returns the same thing as interpreter_frame_last_sp() on all platforms? I didn't think that was true for aarch64. Maybe what we need is a new shared API that will return what the continuation code expects, or promote interpreter_frame_last_sp() to be shared.

Indeed. AArch64 makes a strong distinction between the machine SP and the interpreter's expression SP, and much of the difficulty with that port was because it was difficult to tell which was which in shared and x86 code. I wouldn't be able to guarantee that using unextended_sp() was always safe.

-------------

PR: https://git.openjdk.org/jdk/pull/9411


More information about the hotspot-compiler-dev mailing list