RFR: 8287396 LIR_Opr::vreg_number() and data() can return negative number [v2]

Dean Long dlong at openjdk.java.net
Wed Jun 1 07:40:33 UTC 2022


On Sat, 28 May 2022 02:21:35 GMT, Dean Long <dlong at openjdk.org> wrote:

>> This PR does two things:
>> - reverts the incorrect change to non_data_bits that included pointer_bits
>> - treats the data() as an unsigned int to prevent a high bit being treated as a negative number
>
> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
> 
>   set vreg_max to a more reasonable limit (10000)

Thanks Christian.  My first performance run showed some 1-2% regressions on a microbenchmark and a startup benchmark, so I ran it again and the regression disappeared, so I think it was noise.  There was no regression for larger benchmarks like SPECjvm2008.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8912


More information about the hotspot-compiler-dev mailing list