RFR: 8285868: x86 intrinsics for floating point method isInfinite [v13]
Srinivas Vamsi Parasa
duke at openjdk.java.net
Wed Jun 1 16:16:42 UTC 2022
On Wed, 1 Jun 2022 15:24:19 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Support only IsInfinite with vfpclasss/d instruction
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 5335:
>
>> 5333:
>> 5334: void C2_MacroAssembler::double_class_check_vfp(int opcode, Register dst, XMMRegister src, KRegister tmp) {
>> 5335: uint8_t imm8;
>
> May be ok to move it back to instruction encoding block , only two instructions.
That's true. The two instructions can be put in the instruction encoding block. Will do that.
> src/hotspot/cpu/x86/x86.ad line 10148:
>
>> 10146: instruct FloatClassCheck_reg_reg_vfpclass(rRegI dst, regF src, kReg ktmp, rFlagsReg cr)
>> 10147: %{
>> 10148: predicate(VM_Version::supports_avx512dq());
>
> Predicate is no longer needed you have done the check in match_rule_supported routine.
That's true, the check is already done in the match rule. Will update the code.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8459
More information about the hotspot-compiler-dev
mailing list