RFR: 8283775: better dump: VM support for graph querying in debugger with BFS traversal and node filtering [v27]

[Emanuel Peter]

On Thu, 2 Jun 2022 14:02:53 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   write out chained assignment
>
> src/hotspot/share/opto/callnode.hpp line 659:
> 
>> 657: 
>> 658: #ifndef PRODUCT
>> 659:   virtual void        dump_req(outputStream *st = tty, DumpConfig* dc = nullptr) const;
> 
> `*` should be left at the type:
> Suggestion:
> 
>   virtual void        dump_req(outputStream* st = tty, DumpConfig* dc = nullptr) const;

done

> src/hotspot/share/opto/node.cpp line 1770:
> 
>> 1768:   Node* old_node(Node* n); // mach node -> prior IR node
>> 1769:   void print_node_idx(Node* n); // to tty
>> 1770:   void print_node_block(Node* n); // to tty: head idx, _idom, _dom_depth
> 
> Can all be made `static`.

done

> src/hotspot/share/opto/node.cpp line 2327:
> 
>> 2325: 
>> 2326: // -----------------------------dump_idx---------------------------------------
>> 2327: void Node::dump_idx(bool align, outputStream *st, DumpConfig* dc) const {
> 
> Suggestion:
> 
> void Node::dump_idx(bool align, outputStream* st, DumpConfig* dc) const {

done

> src/hotspot/share/opto/node.cpp line 2333:
> 
>> 2331:   Compile* C = Compile::current();
>> 2332:   bool is_new = C->node_arena()->contains(this);
>> 2333:   if(align) { // print prefix empty spaces$
> 
> Suggestion:
> 
>   if (align) { // print prefix empty spaces$

done

> src/hotspot/share/opto/node.cpp line 2338:
> 
>> 2336:     // +1 for leading digit, maybe +1 for "o"
>> 2337:     uint width = log10(_idx) + 1 + (is_new ? 0 : 1);
>> 2338:     while(max_width > width) {
> 
> Suggestion:
> 
>     while (max_width > width) {

done

> src/hotspot/share/opto/node.cpp line 2343:
> 
>> 2341:     }
>> 2342:   }
>> 2343:   if(!is_new) {
> 
> Suggestion:
> 
>   if (!is_new) {

done

> src/hotspot/share/opto/node.cpp line 2353:
> 
>> 2351: 
>> 2352: // -----------------------------dump_name--------------------------------------
>> 2353: void Node::dump_name(outputStream *st, DumpConfig* dc) const {
> 
> Suggestion:
> 
> void Node::dump_name(outputStream* st, DumpConfig* dc) const {

done

-------------

PR: https://git.openjdk.java.net/jdk/pull/8468