RFR: 8286104: use aggressive liveness for unstable_if traps [v11]

Xin Liu xliu at openjdk.java.net
Mon Jun 6 20:42:25 UTC 2022


On Mon, 6 Jun 2022 17:08:46 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Bail out if fold-compares sees that a unstable_if trap has modified.
>>   
>>   Also add a regression test
>
> src/hotspot/share/opto/compile.hpp line 811:
> 
>> 809:                                              _dead_node_count = 0;
>> 810:                                            }
>> 811:   void         record_unstable_if(UnstableIfTrap* trap);
> 
> You missed to rename method to record_unstable_if_trap().
> The placement of declaration is strange. Can you move to other `unstable_if_trap` declared methods?

yes, my fault. I rename it and group them.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8545


More information about the hotspot-compiler-dev mailing list