RFR: 8286990: Add compiler name to warning messages in Compiler Directive [v3]

Tobias Hartmann thartmann at openjdk.java.net
Tue Jun 7 09:26:06 UTC 2022


On Tue, 31 May 2022 03:22:46 GMT, Yuta Sato <duke at openjdk.java.net> wrote:

>> When using Compiler Directive such as `java -XX:+UnlockDiagnosticVMOptions -XX:CompilerDirectivesFile=<CompilerDirectives.json> <Java.class>` ,
>> it shows totally the same message for c1 and c2 compiler and the user would be confused about 
>> which compiler is affected by this message.
>> This should show messages with their compiler name so that the user knows which compiler shows this message.
>> 
>> My change result would be like the below.
>> 
>> 
>> OpenJDK 64-Bit Server VM warning: printing of assembly code is enabled; turning on DebugNonSafepoints to gain additional output
>> OpenJDK 64-Bit Server VM warning: printing of assembly code is enabled; turning on DebugNonSafepoints to gain additional output
>> 
>> ->
>> 
>> OpenJDK 64-Bit Server VM warning: c1: printing of assembly code is enabled; turning on DebugNonSafepoints to gain additional output
>> OpenJDK 64-Bit Server VM warning: c2: printing of assembly code is enabled; turning on DebugNonSafepoints to gain additional output
>
> Yuta Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add const to method

Looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8591


More information about the hotspot-compiler-dev mailing list