RFR: 8287493: 32-bit Windows build failure in codeBlob.cpp after JDK-8283689
Aleksey Shipilev
shade at openjdk.java.net
Wed Jun 8 18:25:37 UTC 2022
On Wed, 8 Jun 2022 18:18:58 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:
>> See the bug report for example build failure. This breakage is widely seen on many build servers. The fix follows what [https://bugs.openjdk.org/browse/JDK-8210803](JDK-8210803) did for other blobs.
>>
>> Additional testing:
>> - [x] Windows x86_32 fastdebug build
>> - [x] Linux x86_64 fastdebug `java/foreign`
>
> src/hotspot/share/code/codeBlob.hpp line 773:
>
>> 771: // below two-argument operator delete will be treated as a placement
>> 772: // delete rather than an ordinary sized delete; see C++14 3.7.4.2/p2.
>> 773: void operator delete(void* p);
>
> I suggest to move this delete operator to RuntimeBlob to avoid adding this method in potential new subclasses.
Not sure how well that works with non-virtual operators. We can consider that as the follow-up cleanup. Meanwhile, I'd like to push this one trivial build fix, OK?
-------------
PR: https://git.openjdk.java.net/jdk/pull/9088
More information about the hotspot-compiler-dev
mailing list