RFR: 8287493: 32-bit Windows build failure in codeBlob.cpp after JDK-8283689

[Jorn Vernee]

On Wed, 8 Jun 2022 16:50:22 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> See the bug report for example build failure. This breakage is widely seen on many build servers. The fix follows what [https://bugs.openjdk.org/browse/JDK-8210803](JDK-8210803) did for other blobs.
> 
> Additional testing:
>  - [x] Windows x86_32 fastdebug build
>  - [x] Linux x86_64 fastdebug `java/foreign`
>  - [x] Windows x86_32 fastdebug `java/foreign`

LGTM.

I thought this wasn't needed since the comment talks about a two-argument operator delete, which we don't have in this class. When I tried removing it everything seemed fine so I went with that.

Maybe good to update the comment here as well... (and maybe even in other places in codeBlob.hpp as well). Since the issue only seems to occur with MSVC on 32-bit platforms (?), I think it would be good to mention that in the comment in case people wonder if removing this operator will cause issues in the future (like me).

-------------

Marked as reviewed by jvernee (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/9088