RFR: 8288078: linux-aarch64-optimized build fails in Tier5 after JDK-8287567

Andrew Haley aph at openjdk.java.net
Thu Jun 9 10:20:44 UTC 2022


On Thu, 9 Jun 2022 09:33:24 GMT, Andrew Haley <aph at openjdk.org> wrote:

> Because neither ASSERT nor PRODUCT are defined in 'optimized' builds , this needs to be surrounded by ASSERT ifdefs, not PRODUCT.

> @theRealAph
> 
> > Because PRODUCT is defined in 'optimized' builds, this needs to be surrounded by ASSERT ifdefs, not PRODUCT.
> 
> I am not sure that comment is correct even though I agree the fix is right. I'll provide my explanation just to be sure I have understood the fix. The error is happening because:
>     1. `PRODUCT` is _not_ defined in 'optimized' builds
> 
>     2. `assert` is defined as an empty macro in 'optimized' builds

Exactly, thanks. I changed my summary text to fit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/9103


More information about the hotspot-compiler-dev mailing list