RFR: 8287525: Extend IR annotation with new options to test specific target feature. [v3]

[Swati Sharma]

On Thu, 9 Jun 2022 07:24:12 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Swati Sharma has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Merge branch 'JDK-8287525' of https://github.com/swati-sha/jdk into JDK-8287525
>>  - 8287525: Review comments resolved.
>
> test/hotspot/jtreg/compiler/lib/ir_framework/test/IREncodingPrinter.java line 201:
> 
>> 199:             applyRules++;
>> 200:             TestFormat.checkNoThrow((irAnno.applyIfCPUFeatureOr().length % 2) == 0,
>> 201:                                     "Argument count for applyIfCPUFeatureOr should be multiple of two" + failAt());
> 
> The format check on L208 cannot be used like that anymore (I can somehow not comment on lines that are hidden):
> 
>         TestFormat.checkNoThrow(applyRules <= 1,
>                                 "Can only specify one apply constraint " + failAt());
> 
> We should be allowed to specify one `applyIf*` flag constraint together with one `applyIfCPUFeature*` constraint while not being allowed to specify multiple `applyIf*` flag constraints and/or multiple `applyIfCPUFeature*` constraints.

Do you suggest commenting out check on L208 to enable application of multiple applyIf* constraints OR should that be handled in a separate RFE.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8999