RFR: 8287835: Add support for additional float/double to integral conversion for x86 [v6]

Sandhya Viswanathan sviswanathan at openjdk.java.net
Fri Jun 10 17:35:13 UTC 2022


On Fri, 10 Jun 2022 07:37:59 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Sandhya Viswanathan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review commit resolution
>
> test/hotspot/jtreg/compiler/vectorapi/VectorFPtoIntCastTest.java line 79:
> 
>> 77:             float_arr[i] = ran.nextFloat();
>> 78:             double_arr[i] = ran.nextDouble();
>> 79:         }
> 
> Can you kindly also add special floating point values NaN, +/-Inf, +/-0.0 to input array to cover your special handling code changes.

@jatin-bhateja The test is only checking the IR node generation for x86. 
The rest of the actual functionality test is already covered under the following including the special cases:
compiler/codegen/TestByteDoubleVect.java compiler/codegen/TestByteFloatVect.java compiler/codegen/TestShortFloatVect.java compiler/codegen/TestShortDoubleVect.java compiler/codegen/TestLongFloatVect.java compiler/codegen/TestIntDoubleVect.java compiler/codegen/TestIntFloatVect.java
The general idea of this PR was to complement x86 FP to integral conversion along with https://git.openjdk.org/jdk/pull/7806 from Fei Gao.

-------------

PR: https://git.openjdk.org/jdk/pull/9032


More information about the hotspot-compiler-dev mailing list