RFR: 8284404: Too aggressive sweeping with Loom

[Tobias Hartmann]

On Tue, 24 May 2022 15:08:28 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

>>> @vnkozlov Is your concern that a user explicitly overrides the default to a value that ends up not being good? If so, I'm not sure why we would be in the business of preventing the user from shooting itself in the foot and guessing what the user really wanted here. Maybe I missed something.
>> 
>> Yes, it was my concern which was unjustifiable because I missed that this code is guarded by `FLAG_IS_DEFAULT(SweeperThreshold)`. So you simply set `SweeperThreshold` to 5% (default is 0.5) which is fine.
>
>> > @vnkozlov Is your concern that a user explicitly overrides the default to a value that ends up not being good? If so, I'm not sure why we would be in the business of preventing the user from shooting itself in the foot and guessing what the user really wanted here. Maybe I missed something.
>> 
>> 
>> 
>> Yes, it was my concern which was unjustifiable because I missed that this code is guarded by `FLAG_IS_DEFAULT(SweeperThreshold)`. So you simply set `SweeperThreshold` to 5% (default is 0.5) which is fine.
> 
> Okay great - thanks for the review!

@fisk This PR needs to be re-submitted for the JDK 19 repository but given it was triaged as P4, it might be too late.

-------------

PR: https://git.openjdk.org/jdk/pull/8673