RFR: 8288281: compiler/vectorapi/VectorFPtoIntCastTest.java failed with "IRViolationException: There were one or multiple IR rule failures."
Christian Hagedorn
chagedorn at openjdk.java.net
Thu Jun 16 07:16:10 UTC 2022
On Thu, 16 Jun 2022 02:34:33 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:
> The IR Framework test was failing due to incorrect node name.
> Corrected the IR node name check.
>
> Please review.
>
> Best Regards,
> Sandhya
Otherwise, looks good!
test/hotspot/jtreg/compiler/vectorapi/VectorFPtoIntCastTest.java line 87:
> 85:
> 86: @Test
> 87: @IR(counts = {"VectorCastF2X", "> 0"})
You can directly use `IRNode.VECTOR_CAST_F2X` (and `IRNode.VECTOR_CAST_D2X` below) which makes it clearer that this is an actual IR node and not a custom string.
-------------
Marked as reviewed by chagedorn (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9177
More information about the hotspot-compiler-dev
mailing list