RFR: 8263384: IGV: Outline should highlight the Graph that has focus [v2]
Tobias Hartmann
thartmann at openjdk.org
Mon Jun 20 06:24:55 UTC 2022
On Thu, 16 Jun 2022 10:22:33 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
>> This changeset eases navigation within and across graph groups by highlighting the focused graph in the Outline window. If the user changes the focus to another graph window, or moves to the previous or next graph within the same window, the newly focused graph is automatically highlighted in the Outline window. This is implemented by maintaining a static map from opened graphs to their corresponding [NetBeans nodes](https://urldefense.com/v3/__https://netbeans.apache.org/tutorials/nbm-selection-2.html__;!!ACWV5N9M2RV99hQ!OgLYtNnI1jrRRnn1yGPthyOWlX4FftUeaXiqy8_Sf6-iZjTgnljiBUh1zG1mfcSrQ5u8u7Zgw28xOHQX-vbcGF_OJ-MYDVYGLg$ ). The Outline window uses the map to select, on a graph focus change, the NetBeans node of the newly focused graph that should be highlighted.
>>
>> Tested manually by opening simultaneously tens of graphs from different groups and switching the focus randomly.
>
> Roberto Castañeda Lozano has updated the pull request incrementally with three additional commits since the last revision:
>
> - Highlight active graph when the Outline window is re-opened
> - Avoid unnecessary setting of 'result' to null
> - Wait for last graph update before highlighting it
Looks reasonable.
-------------
Marked as reviewed by thartmann (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9167
More information about the hotspot-compiler-dev
mailing list