RFR: 8288781: C1: LIR_OpVisitState::maxNumberOfOperands too small

Aleksey Shipilev shade at openjdk.org
Tue Jun 21 14:55:47 UTC 2022


On Tue, 21 Jun 2022 09:13:51 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

> Increment `LIR_OpVisitState::maxNumberOfOperands` by 1 to allow C1 compilation of a method that receives 21 parameters in registers instead of crashing.
> 
> Add regression test. The regression test crashes on ppc because there all parameters (8 integer + 13 float = 21) can be passed in registers.
> 
> The fix passed our CI testing. This includes most JCK and JTREG test, also in Xcomp mode, on the standard platforms and also on Linux/PPC64le.

Looks fine. Last time this was bumped in [JDK-8004051](https://bugs.openjdk.org/browse/JDK-8004051), and there seem to be no recorded regressions for that bump.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.org/jdk19/pull/51


More information about the hotspot-compiler-dev mailing list