RFR: 8289046: Undefined Behaviour in x86 class Assembler [v2]

Aleksey Shipilev shade at openjdk.org
Fri Jun 24 08:12:00 UTC 2022


On Fri, 24 Jun 2022 07:57:15 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> src/hotspot/cpu/x86/globalDefinitions_x86.hpp line 78:
>> 
>>> 76: #endif
>>> 77: 
>>> 78: #define USE_POINTERS_TO_REGISTER_IMPL_ARRAY
>> 
>> So, what's the use for this symbol? I see AArch64 code conditionalize definition macros, but this patch does not have such conditionalization. Should it?
>
> It means we pick up the correct definitions of `CONSTANT_REGISTER_DECLARATION` et al.

Ah, those definitions are in shared code! Nevermind then.

-------------

PR: https://git.openjdk.org/jdk/pull/9261


More information about the hotspot-compiler-dev mailing list