RFR: JDK-8287094: IGV: show node input numbers in edge tooltips [v3]

[Christian Hagedorn]

On Fri, 24 Jun 2022 10:40:31 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:

>> For nodes with many inputs, such as safepoints, it is difficult and error-prone to figure out the exact input number of a given incoming edge. 
>> 
>> Extend the Edge Tooltips to include the input number of the destination node:
>> **Before** `91 Addl -> 92 SafePoint`
>> **Now** `91 Addl -> 92 SafePoint [NR]`
>> ![edge](https://urldefense.com/v3/__https://user-images.githubusercontent.com/71546117/175506945-6f5137d2-7647-4acb-a135-8fcb719df3e6.png__;!!ACWV5N9M2RV99hQ!M3TK1r7wTKRl1aVUPe1yKEG-uRTEXaaUbAXbdb4F1T-vgRhQm9yIRxxqhYSqFfDNQKVQ9fcTAIl-CUInuB72gXjAt95h48xBhw$ )
>
> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert "CustomSelectAction added"
>   
>   This reverts commit 7bc3758905b50df39c188e1e2d90e222839ddedf.

Looks good!

src/utils/IdealGraphVisualizer/Graph/src/main/java/com/sun/hotspot/igv/graph/FigureConnection.java line 108:

> 106:         builder.append(" ��� ");
> 107:         builder.append(getInputSlot().getFigure().getProperties().resolveString(shortNodeText));
> 108:         builder.append(" [" + getInputSlot().getPosition() + "]");

String concatenation could be replaced by `append()` calls to follow the pattern above (the `builder.` can also be removed and the calls be chained together directly):
Suggestion:

        builder.append(" [")
               .append(getInputSlot().getPosition())
               .append("]");

-------------

Marked as reviewed by chagedorn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9273