RFR: JDK-8288750: IGV: Improve Shortcuts [v5]

[Tobias Holenstein]

On Fri, 24 Jun 2022 12:17:11 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added missing files
>
> That's a nice improvement, thanks for fixing these and adding new shortcuts together with icons! I've tried the shortcuts out and they seem to work fine (tested on Ubuntu 20.04). It makes the workflow a lot easier.
> 
> I only have some minor code style comments, otherwise it looks good - but I'm not very familiar with the IGV code.

@chhagedorn and @TobiHartmann thanks for the reviews! :)

> src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/EditorTopComponent.java line 372:
> 
>> 370:         centerPanel.add(SATELLITE_STRING, satelliteComponent);
>> 371: 
>> 372: 
> 
> New line can be removed.

done

> src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/actions/ExpandDiffAction.java line 41:
> 
>> 39:     }
>> 40: 
>> 41:     public ExpandDiffAction(Lookup lookup) {
> 
> `lookup` seems unused. Can be removed?

done

> src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/actions/ShrinkDiffAction.java line 40:
> 
>> 38:     }
>> 39: 
>> 40:     public ShrinkDiffAction(Lookup lookup) {
> 
> `lookup` seems unused. Can be removed?

done

> src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/actions/ShrinkDiffAction.java line 67:
> 
>> 65:             int nfp = fp;
>> 66:             int nsp = (fp < sp) ? sp - 1 : sp;
>> 67:             model.setPositions(nfp, nsp);
> 
> `nfp` can be inlined directly. Maybe you want to rename the variables instead of using abbreviations. Same in `ExpandDiffAction`.

done

-------------

PR: https://git.openjdk.org/jdk/pull/9260