RFR: 8286941: Add mask IR for partial vector operations for ARM SVE [v7]
Xiaohong Gong
xgong at openjdk.org
Thu Jun 30 08:35:53 UTC 2022
On Thu, 30 Jun 2022 08:28:47 GMT, Nick Gasson <ngasson at openjdk.org> wrote:
>> Xiaohong Gong has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix assembler test issue
>
> src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp line 1409:
>
>> 1407: // Encode to "whilelow" for the remaining cases.
>> 1408: mov(rscratch1, lane_cnt);
>> 1409: sve_whilelow(dst, size, zr, rscratch1);
>
> Why not move these two lines into an `else {` block and then you can get rid of the early returns on lines 1398, 1401, and 1404? I think that would make the logic easier to follow.
Good idea! Thanks, I will change this later.
-------------
PR: https://git.openjdk.org/jdk/pull/9037
More information about the hotspot-compiler-dev
mailing list