Integrated: 8281811: assert(_base == Tuple) failed: Not a Tuple after JDK-8280799

[Roland Westrelin]

On Wed, 16 Feb 2022 13:28:48 GMT, Roland Westrelin <roland at openjdk.org> wrote:

> The crash occurs because a Shenandoah barrier is expanded between the
> Start node and its control projection. One of the test cases I added
> also shows the same failure with a barrier expansion between a MemBar
> and its control projection. The barrier is expanded at the control
> that PhaseIdealLoop assigns to it.
> 
> This code:
> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/loopnode.cpp#L5756
> I added back with JDK-8280799 is what's causing the incorrect
> placement of the barrier.
> 
> The fix I propose is to skip that logic if the loop opts pass is for
> barrier expansion as there's no range check elimination then.

This pull request has now been integrated.

Changeset: fcce24c5
Author:    Roland Westrelin <roland at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/fcce24c5b3cd1dab755fd9b6779af71f4dd78773
Stats:     88 lines in 3 files changed: 74 ins; 0 del; 14 mod

8281811: assert(_base == Tuple) failed: Not a Tuple after JDK-8280799

Reviewed-by: kvn, thartmann

-------------

PR: https://git.openjdk.java.net/jdk/pull/7494