RFR: 8277055: Assert "missing inlining msg" with -XX:+PrintIntrinsics [v2]

Tobias Hartmann thartmann at openjdk.java.net
Tue Mar 1 14:13:51 UTC 2022


On Tue, 1 Mar 2022 14:09:38 GMT, Tobias Holenstein <duke at openjdk.java.net> wrote:

>> in `CallGenerator::do_late_inline_helper()` we hit an assert `"missing inlining msg"` when calling  `C->print_inlining_update_delayed(this)`. The reason is that not all implementations of do_late_inline_check() print an inline message. The fix is to add an inline message for the two `return false` in `LateInlineVirtualCallGenerator::do_late_inline_check(...)` where we do not print an inline message.
>> 
>> Tier1-3 passed
>
> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   more detailed message

Looks good to me too. Thanks for updating the inlining message to include the reason.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7385


More information about the hotspot-compiler-dev mailing list