RFR: 8282573: ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y) [v2]

[Daniel D.Daugherty]

On Thu, 3 Mar 2022 16:26:41 GMT, Emanuel Peter <duke at openjdk.java.net> wrote:

>> There are two functions that check for equality.
>> void ck(long x, long y): already throws a RuntimeException if we observe inequality
>> void ck(double x, double y): called itself, leading to endless recursion and a StackOverflowError.
>> 
>> Instead of the recursion, I now also throw a RuntimeException.
>> 
>> This can currently be triggered with
>> `path-to-jtreg/jtreg -va -s -jdk:jdk-path -javaoptions:"-XX:+UnlockDiagnosticVMOptions -XX:-TieredCompilation -XX:+StressGCM -XX:+OptoScheduling -XX:StressSeed=293843391" test/hotspot/jtreg/compiler/intrinsics/unsafe/HeapByteBufferTest.java `
>> (see bug [JDK-8282555](https://bugs.openjdk.java.net/browse/JDK-8282555))
>> 
>> This way I could verify that instead of StackOverflowError we now get RuntimeException, as desired.
>> Ran some basic tests to ensure I didn't break things.
>
> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed unnecessary conditions

test/hotspot/jtreg/compiler/intrinsics/unsafe/ByteBufferTest.java line 220:

> 218:     void ck(double x, double y) {
> 219:         if (x != y) {
> 220:             throw new RuntimeException(" x = " + Double.toString(x) + ", y = " + Double.toString(y)

You might want to add some explanation to the exception:
s/" x = "/"Expected x == y: x = "

or something like that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7674