RFR: 8282715: typo compileony in test Test8005033.java
Jie Fu
jiefu at openjdk.java.net
Mon Mar 7 06:03:02 UTC 2022
On Mon, 7 Mar 2022 05:33:26 GMT, Xin Liu <xliu at openjdk.org> wrote:
> This patch doesn't change the testing functionality. It was compiled before. HotSpot failed to handle compiler directive 'compileony'. As a result, it has to compile all methods.
>
> Here is the warning message
>
> CompileCommand: An error occurred during parsing
> Error: Unrecognized option 'compileony'
> Line: 'compileony,compiler.codegen.Test8005033::testBitCount'
>
> Usage: '-XX:CompileCommand=<option>,<method pattern>' - to set boolean option to true
> Usage: '-XX:CompileCommand=<option>,<method pattern>,<value>'
> Use: '-XX:CompileCommand=help' for more information and to list all option.
>
> After correcting the typo, hotspot only compiles the method it is supposed to test. Test time of fastdebug build reduces from 16.778s to 0.226s.
test/hotspot/jtreg/compiler/codegen/Test8005033.java line 2:
> 1: /*
> 2: * Copyright (c) 2012, 2022 SAP SE. All rights reserved.
We'd better not change the copyright line other than Oracle's.
Maybe, you can start a newline of yours after it.
test/hotspot/jtreg/compiler/codegen/Test8005033.java line 30:
> 28: *
> 29: * @run main/othervm -Xcomp
> 30: * -XX:CompileCommand=compileonly,compiler.codegen.Test8005033::testBitCount
This looks reasonable to me.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7718
More information about the hotspot-compiler-dev
mailing list