RFR: 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y) [v2]
Emanuel Peter
duke at openjdk.java.net
Mon Mar 7 10:25:47 UTC 2022
> Until now, ck for doubles ignored the case when either x or y was NaN, it for example would let pass x=NaN and y=2.0.
> Further, instead of throwing an exception, it went into infinite recursion, with an eventual StackOverflowError.
> Now, we throw an exception that prints the values. I fixed the logic, and added an explanation.
>
> All tests are passing.
Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
state reason for failure in Exception
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7723/files
- new: https://git.openjdk.java.net/jdk/pull/7723/files/9bee927f..a96fbb5d
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7723&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7723&range=00-01
Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod
Patch: https://git.openjdk.java.net/jdk/pull/7723.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/7723/head:pull/7723
PR: https://git.openjdk.java.net/jdk/pull/7723
More information about the hotspot-compiler-dev
mailing list