RFR: 8278296: Generalize long range check transformation [v5]

[Roland Westrelin]

On Wed, 9 Feb 2022 07:40:29 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> Executed some quick testing and the build failed:
> 
> [2022-02-09T07:35:21,066Z] /System/Volumes/Data/mesos/work_dir/slaves/c82600aa-2448-475c-8c08-6f02a5b3f3af-S24361/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd-0196/executors/a8285c9b-cd39-45ef-ab77-b0841e9ffa80/runs/2f83fde2-cc8b-421e-90d1-b402cd6b2d90/workspace/open/src/hotspot/share/opto/loopTransform.cpp:2574:47: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
> [2022-02-09T07:35:21,066Z]     if (is_iv(exp->in(which = 1), iv, exp_bt) && exp->in(2)->is_Con() ||
> [2022-02-09T07:35:21,066Z]         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ ~~
> [2022-02-09T07:35:21,066Z] /System/Volumes/Data/mesos/work_dir/slaves/c82600aa-2448-475c-8c08-6f02a5b3f3af-S24361/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd-0196/executors/a8285c9b-cd39-45ef-ab77-b0841e9ffa80/runs/2f83fde2-cc8b-421e-90d1-b402cd6b2d90/workspace/open/src/hotspot/share/opto/loopTransform.cpp:2574:47: note: place parentheses around the '&&' expression to silence this warning
> [2022-02-09T07:35:21,066Z]     if (is_iv(exp->in(which = 1), iv, exp_bt) && exp->in(2)->is_Con() ||
> [2022-02-09T07:35:21,067Z]                                               ^
> [2022-02-09T07:35:21,067Z]         (                                                            )
> [2022-02-09T07:35:21,067Z] /System/Volumes/Data/mesos/work_dir/slaves/c82600aa-2448-475c-8c08-6f02a5b3f3af-S24361/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd-0196/executors/a8285c9b-cd39-45ef-ab77-b0841e9ffa80/runs/2f83fde2-cc8b-421e-90d1-b402cd6b2d90/workspace/open/src/hotspot/share/opto/loopTransform.cpp:2575:47: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
> [2022-02-09T07:35:21,067Z]         is_iv(exp->in(which = 2), iv, exp_bt) && exp->in(1)->is_Con()) {
> [2022-02-09T07:35:21,067Z]         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
> [2022-02-09T07:35:21,067Z] /System/Volumes/Data/mesos/work_dir/slaves/c82600aa-2448-475c-8c08-6f02a5b3f3af-S24361/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd-0196/executors/a8285c9b-cd39-45ef-ab77-b0841e9ffa80/runs/2f83fde2-cc8b-421e-90d1-b402cd6b2d90/workspace/open/src/hotspot/share/opto/loopTransform.cpp:2575:47: note: place parentheses around the '&&' expression to silence this warning
> [2022-02-09T07:35:21,067Z]         is_iv(exp->in(which = 2), iv, exp_bt) && exp->in(1)->is_Con()) {
> [2022-02-09T07:35:21,067Z]                                               ^

@TobiHartmann thanks for the review/testing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6989