RFR: 8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly [v2]

[Foivos]

On Mon, 7 Mar 2022 09:52:15 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Foivos has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   Fix handling of hidden classes in MetaUtil
>>   
>>   7cc137105928ec109a29d9315565f7f49af3cf2b introduced hidden classes with
>>   internal names like com/example/Foo.1234 that get changed to
>>   com.example.Foo/1234 by Class.getName() which are not properly handled
>>   by MetaUtil's toInternalName and internalNameToJava
>
> src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/MetaUtil.java line 127:
> 
>> 125:         switch (name.charAt(0)) {
>> 126:             case 'L': {
>> 127:                 String result = replacePackageAndHiddenSeparators(name.substring(1, name.length() - 1), '/', '.');
> 
> Consider extracting constants `/` (as `PACKAGE_SEP_INTERNAL` perhaps)  and `.` (as `HIDDEN_SEP_INTERNAL`). You could then also create the inversely defined constants `PACKAGE_SEP_JAVA` and `HIDDEN_SEP_JAVA`. It would make the code slightly easier to read.

�� 

Done!

-------------

PR: https://git.openjdk.java.net/jdk/pull/7346