RFR: 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y) [v2]
Emanuel Peter
duke at openjdk.java.net
Tue Mar 8 09:25:52 UTC 2022
On Mon, 7 Mar 2022 23:24:16 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> state reason for failure in Exception
>
> I wonder if we can simplify and replace the test with `Double.compare(x, y) != 0`? Can you test that?
>
> That introduces a new condition since `-0.0 == 0.0` is `true` (yes, another odd difference!) where as `Double.compare(-0.0, 0.0) != 0`
Thanks @PaulSandoz , I changed it and ran the tests again.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7723
More information about the hotspot-compiler-dev
mailing list