RFR: 8282715: typo compileony in test Test8005033.java [v2]

Xin Liu xliu at openjdk.java.net
Tue Mar 8 09:44:01 UTC 2022


On Tue, 8 Mar 2022 04:45:32 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/codegen/Test8005033.java line 2:
>> 
>>> 1: /*
>>> 2:  * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
>> 
>> Since this file was first created by SAP, I would suggest adding yours after SAP's copyright line.
>> Thanks.
>
> IANAL But a simple typo fix doesn't seem worthy of a copyright claim.

> The fix is good but I still don't understands why we don't see the test fail with:
> 
> CompileCommand: An error occurred during parsing Error: Unrecognized option 'compileony' Line: 'compileony,compiler.codegen.Test8005033::testBitCount'
> 
> ??

yes, it's a warning not an error.  It doesn't change this test, the only difference is that it was slower. 
`-Xcomp` still takes effect and compiled all methods HotSpot encounters.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7718


More information about the hotspot-compiler-dev mailing list