RFR: 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y) [v3]

Tobias Hartmann thartmann at openjdk.java.net
Tue Mar 8 12:59:10 UTC 2022


On Tue, 8 Mar 2022 09:25:51 GMT, Emanuel Peter <duke at openjdk.java.net> wrote:

>> Until now, ck for doubles ignored the case when either x or y was NaN, it for example would let pass x=NaN and y=2.0.
>> Further, instead of throwing an exception, it went into infinite recursion, with an eventual StackOverflowError.
>> Now, we throw an exception that prints the values. I fixed the logic, and added an explanation.
>> 
>> All tests are passing.
>
> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   simplify

Looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7723


More information about the hotspot-compiler-dev mailing list