Integrated: 8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly

Foivos duke at openjdk.java.net
Tue Mar 8 15:40:07 UTC 2022


On Fri, 4 Feb 2022 12:01:46 GMT, Foivos <duke at openjdk.java.net> wrote:

> https://github.com/openjdk/jdk/commit/7cc137105928ec109a29d9315565f7f49af3cf2b introduced hidden classes with internal names like `com/example/Foo.1234` that get changed to `com.example.Foo/1234` by `Class.getName()` which are not properly handled by `MetaUtil`'s `toInternalName` and `internalNameToJava`
> 
> This PR fixes this along with the corresponding test that used to work on the assumption that the internal class names didn't contain the `.` character and that java class names didn't contain the `/` character except for lambdas (which are now treated as hidden classes as well), an assumption that no longer holds.

This pull request has now been integrated.

Changeset: 0cbc4b85
Author:    Foivos Zakkak <fzakkak at redhat.com>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/0cbc4b85bf8ab2ccfb8762322098c4cc7996df7d
Stats:     46 lines in 2 files changed: 20 ins; 5 del; 21 mod

8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly

Reviewed-by: sgehwolf, dnsimon

-------------

PR: https://git.openjdk.java.net/jdk/pull/7346


More information about the hotspot-compiler-dev mailing list