RFR: 8282509: [exploded image] ResolvedClassTest fails with similar output [v3]
Martin Doerr
mdoerr at openjdk.java.net
Wed Mar 9 15:28:11 UTC 2022
On Mon, 7 Mar 2022 16:25:25 GMT, Tyler Steele <duke at openjdk.java.net> wrote:
>> This is a tentative solution to a failure observed on AIX. The solution is tentative because I require help to ensure that something deeper and more problematic is not happening.
>>
>> The test fails because the output produced by PrintCompilation produces `LambdaForm$MH/0x00000007c0002400` instead of `Invokers$Holder` as it does on other platforms. There is one other place the output is different, when `DirectMethodHandle$Holder` is replaced with `LambdaForm$DMH/0x00000007c0001c00`. Ignoring these name changes, the output of PrintCompilation is identical. I observe the same compilations (including the OSR/non-OSR, and same level) in the same order.
>>
>> I would be grateful for help understanding the root of the difference behind the change. I have a few ideas, but I will let you build your own interpretations free from my potentially incorrect understanding (i.e. no spoilers). Thanks in advance.
>
> Tyler Steele has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>
> - Remove leading chars not present in original test
> - Trial Solution: Replaces shouldContain with shouldMatch + Regex in ResolvedClassTest
I've added your additional hint to the issue and linked both issues. Thanks for your investigation.
Your fix could be considered as trivial, but the underlying issue is not. So, please wait for a 2nd review!
The test name in title is not yet correct: Please use "ResolvedClassTest"
-------------
PR: https://git.openjdk.java.net/jdk/pull/7701
More information about the hotspot-compiler-dev
mailing list