RFR: 8282355: compiler/arguments/TestCodeEntryAlignment.java failed "guarantee(sect->end() <= tend) failed: sanity" [v2]

Jie Fu jiefu at openjdk.java.net
Mon Mar 14 09:01:49 UTC 2022


On Mon, 14 Mar 2022 08:31:46 GMT, Dean Long <dlong at openjdk.org> wrote:

>> src/hotspot/share/runtime/stubRoutines.cpp line 219:
>> 
>>> 217:     TraceTime timer("StubRoutines generation 1", TRACETIME_LOG(Info, startuptime));
>>> 218:     // Add extra space for large CodeEntryAlignment
>>> 219:     int max_stubs = 10;
>> 
>> Thanks for your update.
>> 
>> There are about 30 stubs (max number of stubs) to be generated in `generate_initial()` for x86_64.
>> Why not `max_stubs = 30` ?
>
> I instrumented the align() call in my private build to count how many used align(CodeEntryAlignment), and I counted only 7, then I rounded up to 10.  Maybe I should change the name to max_aligned_stubs to make it more clear?

`max_aligned_stubs` is fine to me.
Please also update the copyright year.
Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7800


More information about the hotspot-compiler-dev mailing list