RFR: 8283085: AArch64: No need to leave a breadcrumb for JavaFrameAnchor::capture_last_Java_pc when leaf call

[Andrew Haley]

On Tue, 15 Mar 2022 09:22:14 GMT, Denghui Dong <ddong at openjdk.org> wrote:

> Hi,
> 
> Could I have a review of this fix that remove the breadcrumb in `aarch64_enc_java_to_runtime` for `Op_CallLeaf`, `Op_CallLeafNoFP` and `Op_CallNative`.
> 
> For more details please refer to the description of the issue.
> 
> Thanks,
> Denghui

While I can see the attraction of this, I don't think we should do it.
It removes information that may be used by the stack unwinder to get accurate stack traces through the transition from Java to native code. Without it, I don't think there's any way for the unwinder to get that information for a crash dump, even with PreserveFramePointer enabled.
See 8277948 for some recent changes in this area.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7815