RFR: 8283085: AArch64: No need to leave a breadcrumb for JavaFrameAnchor::capture_last_Java_pc when leaf call

Andrew Haley aph at openjdk.java.net
Wed Mar 16 11:11:47 UTC 2022


On Wed, 16 Mar 2022 03:50:39 GMT, Denghui Dong <ddong at openjdk.org> wrote:

> > See 8277948 for some recent changes in this area.
> 
> Hi, I did a quick try and didn't see this patch break the stack trace when PreserveFramePointer is enabled.

Yes, that's interesting. I just stepped through the code and you may well be right.

I'll have to have a good think about this. I'm reluctant to make changes in this area because stack walking code is used in many places, and it's difficult to check everything. Also, it seems to me that the expected gain from removing the few instructions is quite small, and may be so small that it's immeasurable, so the question is how much time is justified.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7815


More information about the hotspot-compiler-dev mailing list