RFR: 8283229: compiler/arguments/TestCodeEntryAlignment.java fails with release VMs
Dean Long
dlong at openjdk.java.net
Wed Mar 16 20:39:40 UTC 2022
On Wed, 16 Mar 2022 09:35:16 GMT, Jie Fu <jiefu at openjdk.org> wrote:
>> Not running this test in product/release builds seems like the wrong fix. I suggest 2 possible alternatives:
>> 1. Make CodeCacheSegmentSize a product flag. It doesn't make sense to me for CodeCacheSegmentSize (develop flag), CodeEntryAlignment (experimental, product flag), and OptoLoopAlignment (product flag) to be different kinds of flags.
>> 2. Allow CodeEntryAlignment to change the default value of CodeCacheSegmentSize. It would also make sense for OptoLoopAlignment to update the default values of CodeEntryAlignment and CodeCacheSegmentSize.
>
>> 1. Make CodeCacheSegmentSize a product flag. It doesn't make sense to me for CodeCacheSegmentSize (develop flag), CodeEntryAlignment (experimental, product flag), and OptoLoopAlignment (product flag) to be different kinds of flags.
>
> Thanks @dean-long for your review and comments.
> So do we need a CSR if we make CodeCacheSegmentSize a product flag?
@DamonFool I think the right thing to do is to use
@requires vm.debug
for now to fix the test failures, then file a new RFE to make CodeCacheSegmentSize a product flag and clean up the test.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7830
More information about the hotspot-compiler-dev
mailing list